analyzer/runtime: Refactor: Separate download, extract, sqlize steps #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitjat
force-pushed
the
mitjat/runtime-three-step-workflow
branch
2 times, most recently
from
7ddf927
to
51259fb
Compare
mitjat
force-pushed
the
mitjat/runtime-three-step-workflow
branch
2 times, most recently
from
178df7c
to
31dfc19
Compare
…(), prepareEventData()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prework for https://app.clickup.com/t/8669n7f41
The runtime analyzer is currently an amalgamation of the early Emerald code and the imported code from oasis-nexus.
This PR refactors the analyzer to unify their approaches more, though there's still a lot of cleanup opportunities let.
In particular, the PR refactors the analyzer so that each block is processed in three stages:
BlockDatastruct (this was the approach from nexus/EVM/Warren, but the data was only used in some places, while others used the raw structures directly. That makes it a lot harder to rework the structures coming from the node, as we need to do to support multiple versions of oasis-core/oasis-sdk)BlockDatastructure into sql statementsTesting:
Analyzed 5k blocks before and after the refactor, compared DB dumps. No diffs except that the unused
chain.runtime_gas_usedtable is gone.