statecheck: Do not use indexer-internal APIs for node access #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitjat
force-pushed
the
mitjat/statecheck-no-internal-apis
branch
from
5022c00
to
4f51ad8
Compare
aefhm
approved these changes
Mar 24, 2023
|
o good, I can make the diff in #352 smaller |
pro-wh
reviewed
Mar 27, 2023
| require.Nil(t, err) | ||
| oasisClient := conn.Consensus() |
There was a problem hiding this comment.
ℹ️ the factory would do signature.SetChainContext, where the SDK connection doesn't. we have a few .Open(), but luckily they're on registry things that don't use the chain context
There was a problem hiding this comment.
thanks for the tip; i was making the same mistake in the api-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, statecheck used indexer's internal libraries to access the node. This
This PR makes the statecheck depend on the indexer less (actually not at all, except for DB utility wrappers). It does mean that we concede we won't run statecheck on anything but the version of oasis-core and oasis-sdk that it was compiled against. Not a loss IMO; we don't need huge generality there.
Testing: None 😬 because it's a bit of a pain to do, and the changes are such that the compiler should have caught any problems. Also, the statecheck is not hooked up to any alerts yet.