-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodeapi: add automatic runtime history provider #383
Conversation
} | ||
|
||
// ID returns the ID for a Runtime on the provided network. | ||
func (r Runtime) ID(n Network) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only used in statecheck, should move there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks nice!
Two comments:
- Please describe in the PR how you tested this. Should involve an analyzer run for blocks
from..to
wherefrom
andto
are in separate archives (cobalt vs damask) - This does not solve the problem of sapphire needing to use a separate RPC URL. It's actually nicer in terms of a clean scope for the PR this way. I just thought it might make sense to do it together because the sapphire problem will probably require a small rethinking of the config structs. Let's follow up separately.
Thank you also for all the little drive-by housekeeping changes in this PR, neatly in their own commits too. ❤️
9394e77
to
a8ad386
Compare
woo tested. one block in cobalt, one block in damask
|
a8ad386
to
0df32b8
Compare
0df32b8
to
6b0d11f
Compare
use archive node based on runtime round