storage: expose test postgres client and add migrations test #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
changed the title
ptrus
force-pushed
the
ptrus/feature/test-postgres-client
branch
from
0f3a601
to
4621f9f
Compare
mitjat
approved these changes
May 9, 2023
| @@ -34,7 +34,7 @@ jobs: | |||
| ports: | |||
| - 5432:5432 | |||
| env: | |||
| CI_TEST_CONN_STRING: "postgresql://postgres:postgres@127.0.0.1:5432/postgres" | |||
| CI_TEST_CONN_STRING: "postgresql://postgres:postgres@127.0.0.1:5432/postgres?sslmode=disable" | |||
There was a problem hiding this comment.
What changed so that this switch is needed?
There was a problem hiding this comment.
The golang-migrate (library used for migrations) requires it for local db (it tries to use a ssl connection by default).
Before, migrations were never run in unit tests. Other parts of the code (e.g. e2e-tests) already have this configured: https://github.com/oasisprotocol/oasis-indexer/blob/4d3a6adc8765e2414fe82fa2e403771e96535118/tests/e2e_regression/e2e_config.yml#L26
mitjat
force-pushed
the
ptrus/feature/test-postgres-client
branch
from
4621f9f
to
959e05e
Compare
ptrus
force-pushed
the
ptrus/feature/test-postgres-client
branch
from
959e05e
to
c904a0e
Compare
ptrus
force-pushed
the
ptrus/feature/test-postgres-client
branch
from
c904a0e
to
3509fa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a postgres
testutilspackage, which allows connecting to the test database from other tests in the codebase. An analyzer test that executes the migrations is also included as an example of usage (the test ensures migrations are applied without errors).This was needed/useful in #389 and was extracted into a separate PR.