Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obtain RosettaAPIVersion from rosetta-sdk-go #129

Closed
tjanez opened this issue Dec 3, 2020 · 0 comments · Fixed by #279
Closed

Obtain RosettaAPIVersion from rosetta-sdk-go #129

tjanez opened this issue Dec 3, 2020 · 0 comments · Fixed by #279
Milestone
2.0.0

Comments

@tjanez
Copy link
Member

tjanez commented Dec 3, 2020

Instead of hard-coding the Rosetta API version:

https://github.com/oasisprotocol/oasis-core-rosetta-gateway/blob/2b84c4509cb80bab54f1bdb3954a108c4ae8d516/common/version.go#L14-L16

obtain it from rosetta-sdk-go's types.RosettaAPIVersion constant.

It is available in rosetta-sdk-go 0.4.6+, hence this depends on #127.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
1 participant
@tjanez