Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConstructionSubmit should not block on transaction being included in a block #24

Closed
kostko opened this issue Jul 31, 2020 · 1 comment · Fixed by #38
Closed

ConstructionSubmit should not block on transaction being included in a block #24

kostko opened this issue Jul 31, 2020 · 1 comment · Fixed by #38
Labels
bug Something isn't working

Comments

@kostko
Copy link
Member

kostko commented Jul 31, 2020 •
edited
Loading

Based on the Rosetta specification, the ConstructionSubmit endpoint should not block on transaction being included in a block. This requires adding a non-blocking endpoint in Oasis Core first (see oasisprotocol/oasis-core#3152).
@kostko kostko added the bug Something isn't working label Jul 31, 2020
This was referenced Jul 31, 2020
Merged
Merged
@kostko
Copy link
Member Author

kostko commented Aug 6, 2020

The non-blocking endpoint is now available in Oasis Core 20.9.

This was referenced Aug 12, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

construction: switch to SubmitTxNoWait oasisprotocol/oasis-rosetta-gateway
1 participant
@kostko