docker: skip running node if offline var is set #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pro-wh
requested review from
abukosek,
kostko,
peterjgilbert and
tjanez
as code owners
kostko
approved these changes
Feb 11, 2022
tjanez
approved these changes
Feb 11, 2022
|
Hmm... why was CI not run for this PR? |
|
turns out this doesn't work well with the |
|
maybe the ci thing has to do with the base branch |
tjanez
reviewed
Feb 11, 2022
Oh, yeah, that is the reason |
|
@pro-wh, do we want to include this one in the 2.0.0 release? |
sure, if you wouldn't mind rearranging |
pro-wh
force-pushed
the
pro-wh/feature/offline
branch
from
7a12e99
to
cc2c052
Compare
Co-authored-by: Tadej Janež <tadej.j@nez.si>
pro-wh
force-pushed
the
pro-wh/feature/offline
branch
from
cc2c052
to
c750548
Compare
|
rebasing, adding changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is only an optimization. we recommend that users don't rely on software configuration to operate offline.