Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring to later support deleting accounts #1624

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Sep 1, 2023

(this is more resilient in case state gets incorrectly modified)

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 19 0 0.15s
✅ REPOSITORY checkov yes no 43.7s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY grype yes no 18.81s
✅ REPOSITORY trivy-sbom yes no 2.68s
✅ REPOSITORY trufflehog yes no 172.16s
✅ TSX eslint 12 0 0 9.55s
✅ TYPESCRIPT eslint 7 0 0 8.17s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ce9a84
Status: ✅  Deploy successful!
Preview URL: https://9e947f4c.oasis-wallet.pages.dev
Branch Preview URL: https://lw-to-support-deleting-acc.oasis-wallet.pages.dev

View logs

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #1624 (3f432b3) into master (8dfbaec) will decrease coverage by 0.04%.
The diff coverage is 86.84%.

❗ Current head 3f432b3 differs from pull request most recent head 3ce9a84. Consider uploading reports for the commit 3ce9a84 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
- Coverage   82.98%   82.95%   -0.04%     
==========================================
  Files         157      157              
  Lines        4085     4089       +4     
  Branches      731      733       +2     
==========================================
+ Hits         3390     3392       +2     
- Misses        695      697       +2     
Flag Coverage Δ
cypress 51.06% <83.87%> (+0.01%) ⬆️
jest 77.99% <73.68%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/app/state/wallet/index.ts 94.44% <ø> (-0.30%) ⬇️
src/app/state/selectUnlockedStatus.ts 64.28% <58.33%> (+2.74%) ⬆️
src/app/components/Footer/index.tsx 90.90% <100.00%> (ø)
...rc/app/components/MobileFooterNavigation/index.tsx 97.14% <100.00%> (ø)
src/app/components/Sidebar/index.tsx 88.88% <100.00%> (ø)
...s/Toolbar/Features/AccountSelectorButton/index.tsx 95.65% <100.00%> (-4.35%) ⬇️
src/app/components/Toolbar/index.tsx 100.00% <100.00%> (ø)
...ages/AccountPage/Features/AccountSummary/index.tsx 100.00% <100.00%> (ø)
src/app/pages/AccountPage/index.tsx 97.40% <100.00%> (ø)
src/app/state/selectIsAddressInWallet.ts 100.00% <100.00%> (ø)
... and 1 more

... and 4 files with indirect coverage changes

@lukaw3d lukaw3d merged commit 5c0f678 into master Sep 4, 2023
11 checks passed
@lukaw3d lukaw3d deleted the lw/to-support-deleting-acc branch September 4, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants