Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show address name in tx list when address exists in Contacts #1661

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Sep 13, 2023

No description provided.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e94e7f
Status: ✅  Deploy successful!
Preview URL: https://996d4cdb.oasis-wallet.pages.dev
Branch Preview URL: https://mz-contactaddr.oasis-wallet.pages.dev

View logs

@buberdds buberdds force-pushed the mz/contactAddr branch 3 times, most recently from 8d2c33e to 7eefb4b Compare September 13, 2023 11:33
@buberdds buberdds changed the title Show address name when it exists in Contacts Show address name in tx list when address exists in Contacts Sep 13, 2023
@buberdds buberdds marked this pull request as ready for review September 13, 2023 11:34
@buberdds buberdds force-pushed the mz/contactAddr branch 3 times, most recently from 4079e8c to c17674f Compare September 13, 2023 12:25
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #1661 (0e94e7f) into master (5375067) will increase coverage by 0.14%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1661      +/-   ##
==========================================
+ Coverage   82.50%   82.65%   +0.14%     
==========================================
  Files         171      172       +1     
  Lines        4345     4365      +20     
  Branches      777      780       +3     
==========================================
+ Hits         3585     3608      +23     
+ Misses        760      757       -3     
Flag Coverage Δ
cypress 49.54% <18.18%> (-0.11%) ⬇️
jest 77.93% <90.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/styles/theme/ThemeProvider.tsx 100.00% <ø> (ø)
src/app/components/Transaction/index.tsx 83.17% <66.66%> (+0.32%) ⬆️
src/app/components/Transaction/InfoBox.tsx 85.00% <80.00%> (-5.48%) ⬇️
src/app/components/AddressFormatter/index.tsx 100.00% <100.00%> (ø)
src/app/state/contacts/selectors.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

src/styles/theme/ThemeProvider.tsx Outdated Show resolved Hide resolved
@buberdds buberdds merged commit cd69242 into master Sep 14, 2023
12 checks passed
@buberdds buberdds deleted the mz/contactAddr branch September 14, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants