Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refreshing balances on Home page after switching network #1691

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Sep 28, 2023

Fixes #1465

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 177eb29
Status: ✅  Deploy successful!
Preview URL: https://f8cf63b8.oasis-wallet.pages.dev
Branch Preview URL: https://lw-fix-balances-home.oasis-wallet.pages.dev

View logs

* Opened wallet saga
* Will later be used to sign arbitrary messages
*/
export function* walletSaga() {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some checks are failing due to this removal

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1691 (177eb29) into master (35ed8ab) will increase coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1691      +/-   ##
==========================================
+ Coverage   82.83%   82.87%   +0.03%     
==========================================
  Files         175      175              
  Lines        4469     4467       -2     
  Branches      796      796              
==========================================
  Hits         3702     3702              
+ Misses        767      765       -2     
Flag Coverage Δ
cypress 48.53% <20.00%> (-0.21%) ⬇️
jest 78.26% <85.71%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/app/pages/AccountPage/index.tsx 97.18% <100.00%> (-0.22%) ⬇️
src/app/state/wallet/saga.ts 95.00% <83.33%> (-1.06%) ⬇️

... and 3 files with indirect coverage changes

@lukaw3d lukaw3d merged commit b31b357 into master Sep 28, 2023
12 checks passed
@lukaw3d lukaw3d deleted the lw/fix-balances-home branch September 28, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching network on Home screen does not update balances
2 participants