Fix continuously refreshing balances in wallet slice #1692
Conversation
| await expect(page.getByTestId('account-balance-summary')).toContainText('123.0') | ||
| await expect(page.getByTestId('account-choice')).toContainText('123.0') | ||
| await mockApi(page, 456) | ||
| await page.waitForRequest('**/chain/account/info/*', { timeout: 60_000 }) |
There was a problem hiding this comment.
This is a slow test. ACCOUNT_REFETCHING_INTERVAL is 30 seconds. Not sure if we should change it for tests
There was a problem hiding this comment.
based on NODE_ENV? that would be cool, on the other hand Cypress tests are slower than Playwright so not having that would not impact CI heavily. Anyway I'm fine with both, leaving it as is (and making GH issue) or extending PR with configurable interval based on env.
There was a problem hiding this comment.
I changed the interval based on NODE_ENV, but suspiciously test still fails, exceeding timeout
There was a problem hiding this comment.
Changed to REACT_APP_E2E_TEST
Deploying with
|
| Latest commit: |
b25b307
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e680b58d.oasis-wallet.pages.dev |
| Branch Preview URL: | https://lw-fix-wallet-balances.oasis-wallet.pages.dev |
Codecov Report
@@ Coverage Diff @@
## master #1692 +/- ##
==========================================
+ Coverage 82.82% 82.85% +0.03%
==========================================
Files 178 175 -3
Lines 4560 4469 -91
Branches 815 797 -18
==========================================
- Hits 3777 3703 -74
+ Misses 783 766 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lukaw3d
force-pushed
the
lw/fix-wallet-balances
branch
from
fa02cba
to
670b37b
Compare
Fixes making transactions with the refreshed balance and displays new balance in AccountSelector.
lukaw3d
force-pushed
the
lw/fix-wallet-balances
branch
from
670b37b
to
b25b307
Compare
Fixes #1673
Fixes making transactions with the refreshed balance and displays new balance in AccountSelector.