Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename privateKeyPlaceholder to ethPrivateKeyPlaceholder #1736

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Oct 19, 2023

No description provided.

@lukaw3d lukaw3d requested a review from buberdds October 19, 2023 20:09
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Deployed to Cloudflare Pages

Latest commit: f84ebb3b90ded5b789f5f34cb6810465f8b6ad2d
Status:✅ Deploy successful!
Preview URL: https://8c6d9c3b.oasis-wallet.pages.dev

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1736 (b468a2b) into master (0c16bcf) will increase coverage by 0.12%.
The diff coverage is 80.00%.

❗ Current head b468a2b differs from pull request most recent head f84ebb3. Consider uploading reports for the commit f84ebb3 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1736      +/-   ##
==========================================
+ Coverage   82.75%   82.87%   +0.12%     
==========================================
  Files         181      181              
  Lines        4627     4626       -1     
  Branches      826      826              
==========================================
+ Hits         3829     3834       +5     
+ Misses        798      792       -6     
Flag Coverage Δ
cypress 48.58% <60.00%> (+0.01%) ⬆️
jest 78.69% <80.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pages/ParaTimesPage/TransactionRecipient/index.tsx 95.00% <ø> (ø)
src/app/lib/eth-helpers.ts 64.70% <80.00%> (ø)

... and 4 files with indirect coverage changes

@lukaw3d lukaw3d merged commit b05c379 into master Oct 20, 2023
8 checks passed
@lukaw3d lukaw3d deleted the lw/consistent-rename branch October 20, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants