E2E test migrating slightly older V1 state to current RootState #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
force-pushed
the
lw/e2e-persisted-types
branch
from
ee01b60
to
fffb3ed
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1755 +/- ##
==========================================
- Coverage 82.22% 81.98% -0.25%
==========================================
Files 185 186 +1
Lines 4810 4828 +18
Branches 887 887
==========================================
+ Hits 3955 3958 +3
- Misses 855 870 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lukaw3d
force-pushed
the
lw/e2e-persisted-types
branch
from
fffb3ed
to
7cd79c3
Compare
We "removed" some fields throughout time, but didn't add state migration steps. This should be completely fine, types just didn't match test fixtures.
lukaw3d
force-pushed
the
lw/e2e-persisted-types
branch
from
7cd79c3
to
abe0123
Compare
buberdds
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #1756
This somewhat checks if we need a state migration yet, for the current e2e state fixture
privateKeyPersistedState