Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the password in test fixtures #1756

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Nov 16, 2023

I'm planning to use the same password for a test with state from old extension. And old extension had a stricter password policy.

Copy link

github-actions bot commented Nov 16, 2023

Deployed to Cloudflare Pages

Latest commit: bc48bb185fdb51e379b5cfdbac6d8d52a887a091
Status:✅ Deploy successful!
Preview URL: https://56b47a72.oasis-wallet.pages.dev

@buberdds
Copy link
Contributor

something is off with tests exit code 1: Command failed: grep -E...

@lukaw3d
Copy link
Member Author

lukaw3d commented Nov 17, 2023

I don't know what's happening. I think firefox has some heuristic to scrub passwords from session file. I'll try with Abcd1234& instead

@lukaw3d lukaw3d merged commit 32ec470 into master Nov 17, 2023
12 checks passed
@lukaw3d lukaw3d deleted the lw/change-pass-in-fixtures branch November 17, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants