Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use theme to style tabs #1797

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Use theme to style tabs #1797

merged 2 commits into from
Dec 13, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Dec 13, 2023

No description provided.

Copy link

github-actions bot commented Dec 13, 2023

Deployed to Cloudflare Pages

Latest commit: ce21ca81ff6d783a5254a4a36698b61430f7c399
Status:✅ Deploy successful!
Preview URL: https://011821a5.oasis-wallet.pages.dev

@lukaw3d lukaw3d force-pushed the lw/tabs-theme branch 2 times, most recently from 5c8a70f to da0a1c7 Compare December 13, 2023 21:11
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #1797 (5c8a70f) into master (8a3aeda) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 5c8a70f differs from pull request most recent head ce21ca8. Consider uploading reports for the commit ce21ca8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1797      +/-   ##
==========================================
- Coverage   81.44%   81.37%   -0.08%     
==========================================
  Files         191      191              
  Lines        5067     5068       +1     
  Branches      931      931              
==========================================
- Hits         4127     4124       -3     
- Misses        940      944       +4     
Flag Coverage Δ
cypress 45.90% <50.00%> (+0.01%) ⬆️
jest 77.24% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lbar/Features/Account/ManageableAccountDetails.tsx 37.28% <ø> (ø)
...omponents/Toolbar/Features/Contacts/AddContact.tsx 78.26% <ø> (ø)
...nents/Toolbar/Features/Contacts/ContactAccount.tsx 65.62% <ø> (ø)
.../app/components/Toolbar/Features/Profile/index.tsx 100.00% <100.00%> (ø)
...ents/Toolbar/Features/ProfileModalButton/index.tsx 98.18% <ø> (ø)
src/styles/theme/ThemeProvider.tsx 96.66% <100.00%> (+0.11%) ⬆️

... and 3 files with indirect coverage changes

@@ -753,13 +753,6 @@ exports[`<AddContact /> should match snapshot 1`] = `
}
}

@media only screen and (max-width:768px) {
.c18 {
padding-top: 12px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Padding is slightly different, but desktop and mobile look OK.

@lukaw3d lukaw3d merged commit 15d0059 into master Dec 13, 2023
10 checks passed
@lukaw3d lukaw3d deleted the lw/tabs-theme branch December 13, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants