Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a link to disabled ParaTimes page on Ledger accounts #1824

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jan 11, 2024

Before After
localhost_3000_account_oasis1qrf4y7aelwuusc270e8qx04ysr45w3q0zyavrpdk_paratimes (1) localhost_3000_account_oasis1qrf4y7aelwuusc270e8qx04ysr45w3q0zyavrpdk_paratimes

@lukaw3d lukaw3d requested a review from buberdds January 11, 2024 00:21
Copy link

github-actions bot commented Jan 11, 2024

Deployed to Cloudflare Pages

Latest commit: 7ec365a9559df1033fc02d242562d8844478a21f
Status:✅ Deploy successful!
Preview URL: https://4cfc0f08.oasis-wallet.pages.dev

@lukaw3d
Copy link
Member Author

lukaw3d commented Jan 11, 2024

cc @donouwens

@lukaw3d lukaw3d force-pushed the lw/ledger-disabled-paratimes branch from 6d60156 to bac8f22 Compare January 11, 2024 01:11
@lukaw3d lukaw3d force-pushed the lw/ledger-disabled-paratimes branch from bac8f22 to 7ec365a Compare January 11, 2024 01:14
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (31509c8) 81.40% compared to head (7ec365a) 81.44%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1824      +/-   ##
==========================================
+ Coverage   81.40%   81.44%   +0.03%     
==========================================
  Files         192      192              
  Lines        5039     5039              
  Branches      926      923       -3     
==========================================
+ Hits         4102     4104       +2     
+ Misses        937      935       -2     
Flag Coverage Δ
cypress 45.99% <33.33%> (-0.12%) ⬇️
jest 77.34% <81.25%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/app/components/MobileFooterNavigation/index.tsx 96.96% <100.00%> (-0.18%) ⬇️
src/app/components/Sidebar/index.tsx 84.32% <100.00%> (-0.12%) ⬇️
.../app/pages/ParaTimesPage/useParaTimesNavigation.ts 100.00% <100.00%> (ø)
src/app/pages/ParaTimesPage/index.tsx 73.21% <88.88%> (+1.21%) ⬆️
.../ParaTimesPage/ParaTimesPageInaccessible/index.tsx 77.77% <50.00%> (-22.23%) ⬇️

... and 2 files with indirect coverage changes

@lukaw3d lukaw3d merged commit c933e1d into master Jan 11, 2024
11 of 12 checks passed
@lukaw3d lukaw3d deleted the lw/ledger-disabled-paratimes branch January 11, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants