Allow Transak to use more device sensors (fixes E2E tests) #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1832 +/- ##
==========================================
- Coverage 81.19% 81.12% -0.08%
==========================================
Files 192 192
Lines 5053 5053
Branches 933 933
==========================================
- Hits 4103 4099 -4
- Misses 950 954 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
buberdds
approved these changes
Jan 17, 2024
buberdds
reviewed
Jan 17, 2024
| allow="camera;microphone;fullscreen;payment" | ||
| // Expands on https://github.com/Transak/transak-sdk/blob/2ebb3bd/src/index.js#L52 | ||
| // and somewhat matches https://docs.transak.com/docs/web-integration#embediframe-webapp | ||
| allow="accelerometer;camera;microphone;fullscreen;gyroscope;payment" |
There was a problem hiding this comment.
this is weird why they need motion detection.
If we are changing feature policy to make tests happy should we do it only for process?.env?.NODE_ENV === 'test' ?
There was a problem hiding this comment.
It could be for video liveness check (does device movement match the video), but the event listeners get attached much earlier by https://api.sardine.ai/assets/loader.min.js
I'm leaning towards increasing permissions, since we don't have insight into whether this decreases users' ability to complete KYC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.