Update release notes #1848
Update release notes #1848
Conversation
Deployed to Cloudflare Pages
|
| - `yarn changelog`, commit "Assemble changes for ___ release", and merge PR | ||
| - `yarn release-tag` | ||
| ([.github/workflows/release.yml](/.github/workflows/release.yml) then creates | ||
| a github release) | ||
|
|
There was a problem hiding this comment.
My actual steps were:
- yarn changelog, commit, merge
- yarn release-tag
- edit release to mark it pre-release
- ask to deploy the pre-release to staging
- ask to deploy to production
- edit release to mark it latest release
Am I doing it wrong and is yarn release-tag supposed to come after deployment?
There was a problem hiding this comment.
I think you are doing it correctly. release-tag triggers release workflow which is needed for deployment. If pre-release is your default flow you prob want to add prerelease to https://github.com/oasisprotocol/oasis-wallet-web/blob/master/.github/workflows/release.yml
There was a problem hiding this comment.
Luka, in your flow, you are using the criterion of "is it deployed to production at wallet.oasis.io" as a criterion for release (vs. pre-release).
It will be a bit more complex soon when we also build the browser extension from the same code base.
Then the question will become: Is the criteria for the release "is it deployed to production at wallet.oasis.io" AND "is it published at chrome web store"?
Or is it better to untie release/pre-release from these deployment/publish criteria and simply mark the latest version tag as the latest release?
There was a problem hiding this comment.
Annoying :/ if we untie: not ideal if we mark a release while we're still checking staging
| @@ -2,6 +2,18 @@ | |||
|
|
|||
| ## Web wallet | |||
|
|
|||
| Make a release: | |||
|
|
|||
| - ```sh | |||
There was a problem hiding this comment.
is this shell cmd needed in a flow ?
There was a problem hiding this comment.
It's different from the official towncrier, so i think its good to point it out whereever its used. Would be better if changelog.js checked if correct towncrier exists and printed "pip install", but that affects multiple repos
lukaw3d
force-pushed
the
lw/release-notes
branch
from
58ad55e
to
1c49ffb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1848 +/- ##
==========================================
- Coverage 81.22% 81.17% -0.05%
==========================================
Files 192 192
Lines 5064 5067 +3
Branches 933 932 -1
==========================================
Hits 4113 4113
- Misses 951 954 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
No description provided.