Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update buttons layout in mobile settings and fix double scrollbar in extension #1850

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Update buttons layout in mobile settings and fix double scrollbar in extension #1850

merged 4 commits into from
Feb 16, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Feb 13, 2024

Before After
wallet dev oasis io_account_oasis1qzwmjwt5nwv6e37kjmnj59yx7kvnsg4q5cga3580(extension360x600) localhost_3000_account_oasis1qzwmjwt5nwv6e37kjmnj59yx7kvnsg4q5cga3580(extension360x600)
wallet dev oasis io_account_oasis1qzwmjwt5nwv6e37kjmnj59yx7kvnsg4q5cga3580(extension360x600) (1) localhost_3000_account_oasis1qzwmjwt5nwv6e37kjmnj59yx7kvnsg4q5cga3580(extension360x600) (1)
wallet dev oasis io_account_oasis1qpqn3nekz6a6we8e3z5wc0d5ng3qfxeyjcvv7gd6(extension360x600) localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km(extension360x600)
wallet dev oasis io_account_oasis1qpqn3nekz6a6we8e3z5wc0d5ng3qfxeyjcvv7gd6(extension360x600) (1) localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km(extension360x600) (1)
wallet dev oasis io_account_oasis1qpqn3nekz6a6we8e3z5wc0d5ng3qfxeyjcvv7gd6(extension360x600) (2) localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km(extension360x600) (2)
wallet dev oasis io_account_oasis1qpqn3nekz6a6we8e3z5wc0d5ng3qfxeyjcvv7gd6(extension360x600) (3) localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km(extension360x600) (3)

cc @donouwens

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited

Deployed to Cloudflare Pages

Latest commit: 66cde90085a3b585034077ccaa710c8ca55843b5
Status:✅ Deploy successful!
Preview URL: https://4efcd74e.oasis-wallet.pages.dev

@buberdds
Copy link
Contributor

Useful clean up

  • Do we need "Select" button in "My Accounts"? It acts as "Close window"
  • With Lock/Close in Profile tab do we want to keep the same action in app sidebar (bottom left). Not sure if Don was aiming to move everything from sidebar to dropdown

buberdds
buberdds approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@buberdds buberdds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing test

@lukaw3d
Copy link
Member Author

lukaw3d commented Feb 15, 2024

  • We currently don't need Select, but I think clicking on accounts is not supposed to auto-select them in the future
  • 🤷

@lukaw3d lukaw3d merged commit 292650f into master Feb 16, 2024
11 of 12 checks passed
@lukaw3d lukaw3d deleted the lw/setting-btns branch February 16, 2024 02:17
@lukaw3d lukaw3d mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buberdds buberdds buberdds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukaw3d @buberdds