Rename to ROSE Wallet #1870
Merged
Rename to ROSE Wallet #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lukaw3d
commented
Apr 5, 2024
lukaw3d
commented
| Before | After |
|---|---|
 |
 |
 |
 |
 |
 |
Deployed to Cloudflare Pages
|
|
cc @donouwens |
This comment was marked as resolved.
This comment was marked as resolved.
lubej
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
I am just giving LGTM, but would rather see if @buberdds looks at it as well, as he is more familiar with the project.
Mobile part looks good so far, need to check if anything breaks(it shouldn't), but we need to replace the icon + splash as it contains references to the old naming. @donouwens
Good point, I wouldn't notice. I'll rather merge now and fix later - deadline |
Sure, no problem. It is not live anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.