Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show expanded sidebar on medium size devices too #1878

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Show expanded sidebar on medium size devices too #1878

merged 3 commits into from
Apr 9, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Apr 9, 2024

Before After
localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km (1) localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km
localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km (3) localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km (2)

@lukaw3d lukaw3d requested review from buberdds and tjanez April 9, 2024 13:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited

Deployed to Cloudflare Pages

Latest commit: a70bb1cd61f113713f43d27d8f3d8eedd247f917
Status:✅ Deploy successful!
Preview URL: https://e2dc569b.oasis-wallet.pages.dev

buberdds
buberdds approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@buberdds buberdds left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there might be some edge cases (like for some random viewport width 777px)

Screenshot from 2024-04-09 17-34-50

if we care we can file an issue

@lukaw3d
Copy link
Member Author

lukaw3d commented Apr 9, 2024

Yeah, I noticed that was happening even before. I'll make an issue

@lukaw3d
Copy link
Member Author

lukaw3d commented Apr 9, 2024

#1881

@lukaw3d lukaw3d merged commit 2037dcd into master Apr 9, 2024
13 checks passed
@lukaw3d lukaw3d deleted the lw/show-sidebar-medium branch April 9, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buberdds buberdds buberdds approved these changes

@tjanez tjanez Awaiting requested review from tjanez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukaw3d @buberdds