Rename to Oasis ROSE Wallet, except in sidebar #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaw3d
changed the title
Deployed to Cloudflare Pages
|
lukaw3d
force-pushed
the
lw/prefix-rose-wallet
branch
from
f280bfd
to
4dc2499
Compare
This comment was marked as resolved.
This comment was marked as resolved.
buberdds
reviewed
Apr 9, 2024
.changelog/1879.breaking.md
Outdated
| @@ -0,0 +1 @@ | |||
| Rename to ROSE Wallet | |||
There was a problem hiding this comment.
- Rename to Oasis ROSE Wallet
- why it's breaking? we do not plan to bump major version with this update, right?
There was a problem hiding this comment.
Im not sure. Process then?
There was a problem hiding this comment.
I would classify it as a feature and not breaking.
We will bump major version when we release extension and web from the same codebase.
|
We should take into account meta tags like title or og:title and use full product name there. |
aw, i liked the tab name: currently google would look like this: currently slack would look like this: @tjanez should we change these to Oasis ROSE Wallet? |
lukaw3d
force-pushed
the
lw/prefix-rose-wallet
branch
from
4dc2499
to
31c4530
Compare
buberdds
approved these changes
Apr 9, 2024
Yes, change these to Oasis ROSE Wallet. |
lukaw3d
changed the title
lukaw3d
force-pushed
the
lw/prefix-rose-wallet
branch
from
31c4530
to
b91a81d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.