Do we need to check chrome.runtime.lastError when popup opens

[lukaw3d]

If background page crashes, and user opens the popup, would it just show default redux state?

[lukaw3d]

https://github.com/oasisprotocol/oasis-wallet-ext/blob/227fa0df99e3ab0ba01ab298b172ba14fdabff47/src/utils/popup.js#L13-L24

[lukaw3d]

from @buberdds:

It looks like we don't need it in new extension for now. lastError is used when extension use callback based extension API. Old extension is using checkForError only for windowType === 'dapp' which is not a case now (interaction with dapps via runtime.onMessage.addListener?)

[lukaw3d]

So lastError wouldn't be set if background page crashed with Cannot read properties of undefined in normal code. And I didn't find another flag that would get set. Luckily we don't have asynchronous code in the background page that can fail, other than sagas that are handled by fatalError. And if synchronous code before wrapStore fails then popup doesn't initialize.

(And webext-redux and webextension-polyfill do check lastError after sendMessage
https://github.com/tshaddix/webext-redux/blob/95ff156b4afe9bfa697e55bfdb32ec116706aba3/src/store/Store.js#L161
https://github.com/tshaddix/webext-redux/blob/95ff156b4afe9bfa697e55bfdb32ec116706aba3/src/wrap-store/wrapStore.js#L169
https://github.com/mozilla/webextension-polyfill/blob/1649d84ad93c6ebb7225a3db44e96c33e6bbb4a7/src/browser-polyfill.js#L100 )