ORIENTATION BUG -

[capitanevs]

Ok That was hard to find. It is well hidden, serious but (maybe) not difficult.

ISOTROPIC Source +
No elements +
HORIZONTAL or VERTICAL KB and Detector => the best focus is in the right position

ISOTROPIC Source +
HORIZONTAL elements +
VERTICAL KB and Detector => the best focus is in the WRONG position

ISOTROPIC Source +
HORIZONTAL elements +
HORIZONTAL KB and Detector => the best focus is in the right position

The bamline layout is the same. BUT the relative differences are not: Notice DeltaZ of kb, it is too long. This means source too far => focal spot shifted at z<0 (orange curve)

Orange curve: the minimum is in the wrong position, others: right position.

[capitanevs]

So, briefly, we have a problem in

OpticalElement.GeneralDistanceFromParent()

[aljosahafner]

GeneralDistanceFromParent() calculates distance as SameOrientation=True and Reference=True, meaning that DeltaZ is correctly calculated.

[aljosahafner]

It is clear what Parent means in code-terms, simply the previous element in the Beamline (as a list). However, it has to be decided once and for all what Parent will mean as a "user" accessible function. This is what GeneralDistanceFromParent is.