Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR solves the issue where the server doesn't acccept multiple connections/requests at once. It will throw connection refused error or even sometimes crash the server.
Approach
Arc
andMutex
for shared values.tokio::spawn
code which is the primary source of this problem.Server.serve()
function and replace it with a standaloneserve
function that will handle the server and thread creation. In this function, the server is wrapped byArc
to allow threads to refer to the same server.Testing
I have modified the test suite to accomodate the changes that I made to the server functionality.
I tested this PR by using a custom Python script to create a multi-threaded request to the server while the server is running on localhost port 3141. Without this changes, the server will throw an error when encountering multi-thread requests.
Chore checklist