Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquery should not be a dependency #24

Closed
dcrockwell opened this issue Jul 10, 2014 · 9 comments
Closed

jquery should not be a dependency #24

dcrockwell opened this issue Jul 10, 2014 · 9 comments

Comments

@dcrockwell
Copy link

We go to great lengths to avoid using bloated libraries like jquery, because 99% of it's code ends up being delivered without being used, which is a huge waste.

Oauth.js currently requires that an entire jquery library be loaded, just to make a single ajax call.

Please remove jquery, as it is an unnecessary dependency.

@shaneog
Copy link

shaneog commented Jul 17, 2014

Might I suggest http://microjs.com/#ajax

@donmccurdy
Copy link

I'd agree with this. It should be possible to handle AJAX functionality using a smaller library, if any. It is only being used for AJAX, yes?

@william26
Copy link
Contributor

Thank you all for your feedback.

jQuery is also used for promises. We're thinking about removing the dependency but we must make sure that everything is retro-compatible.

We'll tell you if we manage to do it in a clean way.

@nodesocket
Copy link

Remove jQuery dependency with angular.js. This should be possible.

@dcrockwell
Copy link
Author

Thanks, @william26. I see the challenge you face with promises. Thanks for taking the time to find the right solution for everybody.

@shaneog
Copy link

shaneog commented Sep 18, 2014

Again I can suggest http://microjs.com/#promises

@nodesocket
Copy link

👍 please can we not inject jQuery automatically. We don't need it.

@frederikaalund
Copy link

Looking forward to this. 👍

@bumpmann
Copy link
Contributor

We have kept the minimum for jquery ajax and included it in the closure so it won't pollute the globals, so we still have the features in a lightweight way.

cf commit 7e18ff4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants