Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Presentation" is capitalised as if it's a defined term, but I can't find a definition #356

Closed
jogu opened this issue Oct 23, 2023 · 5 comments

Comments

@jogu
Copy link

jogu commented Oct 23, 2023

There are various sentences like:

When Key Binding is not enforced, any entity in possession of an SD-JWT Presentation can forward the contents to third parties

where presentation has a capital P as if it's a defined term. Probably it should have an actual definition (I can't find one) but if not it should probably be lower cased?

@Sakurann
Copy link
Collaborator

This is how Presentation is defined in OID4VP:

Presentation: Data that is presented to a specific Verifier, derived from one or more Verifiable Credentials that can be from the same or different Credential Issuers.

https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html#section-2-3.8

and I think it's better define it than just make it lower-case, as the term is used pretty frequently.

@bifurcation
Copy link
Contributor

I don't think just removing the capitalization helps. It's still an undefined term. In the spirit of #374, it seems like we actually want two concepts here, (1) handing someone an Issuer JWT + disclosures, where they can verify its integrity, drop disclosures and/or hand it to someone else, and (2) handing someone an Issuer JWT + disclosures + KB JWT, where the only thing they can do is verify it.

@bc-pi
Copy link
Collaborator

bc-pi commented Mar 1, 2024

I think #384 goes a long way towards addressing this.

I meant #394, sorry.

@Sakurann
Copy link
Collaborator

Sakurann commented Mar 4, 2024

(I think you meant 394, @bc-pi..?)

@bc-pi
Copy link
Collaborator

bc-pi commented Jun 12, 2024

I believe the merging of #394 clears this one up

@bc-pi bc-pi closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants