New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide ABNF #393
Comments
The actual helpfulness of ABNF IMHO really depends on the readers familiarity with ABNF. I don't know that such familiarity is particularity prevalent. But, as long as it's correct, it doesn't hurt to include either. And while I'm not overly familiar with ABNF myself, I know enough to know that that isn't valid ABNF and doesn't quite correctly convey the SD-JWT constructs. I've endeavored* to fix it up but am not 100% sure this is correct either:
* with a bit of help from https://author-tools.ietf.org/abnf |
Looks good to me, thank you! Maybe a small improvement would be to introduce a name for disclosure?
|
That's a good improvement, thanks! |
Looks good to me, and appears valid according to the IETF ABNF parser. |
(SD-JWT-KB part of the ABNF depends on another PR) |
need to wait after #394 is resolved to do a PR. |
It seems like it could be helpful to implementors, allowing them to quickly validate whether what they have is syntactically an SD-JWT or an SD-JWT with key binding. Something like:
The text was updated successfully, but these errors were encountered: