Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test suite for SD-JWT #416

Closed
lukasjhan opened this issue Mar 19, 2024 · 5 comments · Fixed by #425
Closed

Add Test suite for SD-JWT #416

lukasjhan opened this issue Mar 19, 2024 · 5 comments · Fixed by #425
Labels

Comments

@lukasjhan
Copy link
Contributor

lukasjhan commented Mar 19, 2024

HI! I and @yunseorim1116 made a Test suite project for checking SD-JWT implementation.
You can check it here: https://github.com/lukasjhan/sd-jwt-test-api
It was written in TypeScript. It is in API server format and is distributed using docker.

I'm curious about your opinions on this project.
If this is okay, How about write it in a standard document or put it in README?

Thank you

@bc-pi
Copy link
Collaborator

bc-pi commented Apr 4, 2024

Thanks @lukasjhan, it's great to see this kind of work developing. It's not the kind of thing that would be appropriate in an IETF document, however. And it doesn't really fit very well with the "SD-JWT Implementations" of this README but maybe a line there with a name that qualifies it as a test server rather than actual implementation. Something like:

assuming @danielfett and @Sakurann are okay with that though...

@bc-pi
Copy link
Collaborator

bc-pi commented Apr 15, 2024

Go ahead with a PR as such, @lukasjhan.

@bc-pi bc-pi assigned bc-pi and unassigned bc-pi Apr 15, 2024
@lukasjhan
Copy link
Contributor Author

Thank you I'll open a PR :)

@bc-pi
Copy link
Collaborator

bc-pi commented May 15, 2024

Thank you I'll open a PR :)

@lukasjhan can you do this please?

@lukasjhan
Copy link
Contributor Author

@bc-pi sorry for late response :) I created a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants