We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When my model returns nothing for model.getAccessToken because the token doesn't exist in the db, I get two responses. The offending lines are here: https://github.com/oauthjs/express-oauth-server/blob/master/index.js#L49-L52
model.getAccessToken
.catch(function(e) { return handleError(e, req, res); // sends an error response }) .finally(next); // executes after .catch and sends another response
I believe it should be the following, but I am not 100% certain since I'm not very experienced with the flow of promises.
.tap(next) .catch(function(e) { return handleError(e, req, res); });
The text was updated successfully, but these errors were encountered:
Pretty sure this is fixed by getting rid of the .finally(next) statements
.finally(next)
Sorry, something went wrong.
No branches or pull requests
When my model returns nothing for
model.getAccessToken
because the token doesn't exist in the db, I get two responses. The offending lines are here: https://github.com/oauthjs/express-oauth-server/blob/master/index.js#L49-L52I believe it should be the following, but I am not 100% certain since I'm not very experienced with the flow of promises.
The text was updated successfully, but these errors were encountered: