Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for OAuth1 Client class #28

Closed
idan opened this issue May 1, 2012 · 1 comment
Closed

Write tests for OAuth1 Client class #28

idan opened this issue May 1, 2012 · 1 comment

Comments

@idan
Copy link
Collaborator

idan commented May 1, 2012

No description provided.

@ib-lundgren
Copy link
Collaborator

There are many things that would be useful to add as tests. On top of my head ...

  • Tests serve as great documentation, show off the different signature methods with tests, i.e. rsa and plaintext.
  • Requests with application/x-www-form-urlencoded, ensure it affects the signature
  • Requests with non application/x-www-form-urlencoded, ensure it does not affect the signature. For examples see http://en.wikipedia.org/wiki/MIME_type
  • Possible run over a set of sample "real" requests with more complex combinations of query params, headers and body than the usual basic test.
  • Similar to the above would be to generate possible combinations of combinations with nonsensical but valid data and see if there are odd edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants