You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is the final step after PRs #682#726 and #729 : I found out that even the base Client has inconsistent management of the scope attribute.
in prepare_authorization_request and prepare_refresh_token_request if a scope is provided, it is assigned to self forever, overriding any scope provided in the constructor
in parse_request_body_response and prepare_refresh_body, if no scope is provided the one from the constructor is not used !
PR #731 is an attempt to uniformize everything, but I think that we should ask ourselves the question: will it have side-effects ? (are there enough tests as of today to ensure non-regression)
The text was updated successfully, but these errors were encountered:
This is the final step after PRs #682 #726 and #729 : I found out that even the base
Client
has inconsistent management of thescope
attribute.in
prepare_authorization_request
andprepare_refresh_token_request
if ascope
is provided, it is assigned toself
forever, overriding any scope provided in the constructorin
parse_request_body_response
andprepare_refresh_body
, if no scope is provided the one from the constructor is not used !PR #731 is an attempt to uniformize everything, but I think that we should ask ourselves the question: will it have side-effects ? (are there enough tests as of today to ensure non-regression)
The text was updated successfully, but these errors were encountered: