Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2 base Client inconsistent scope handling #730

Closed
smarie opened this issue Apr 19, 2020 · 0 comments
Closed

OAuth2 base Client inconsistent scope handling #730

smarie opened this issue Apr 19, 2020 · 0 comments

Comments

@smarie
Copy link

smarie commented Apr 19, 2020

This is the final step after PRs #682 #726 and #729 : I found out that even the base Client has inconsistent management of the scope attribute.

  • in prepare_authorization_request and prepare_refresh_token_request if a scope is provided, it is assigned to self forever, overriding any scope provided in the constructor

  • in parse_request_body_response and prepare_refresh_body, if no scope is provided the one from the constructor is not used !

PR #731 is an attempt to uniformize everything, but I think that we should ask ourselves the question: will it have side-effects ? (are there enough tests as of today to ensure non-regression)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant