Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] SD-JWT as a W3C VC-DATA-MODEL #110

Closed
Sakurann opened this issue Jul 7, 2022 · 5 comments
Closed

[WIP] SD-JWT as a W3C VC-DATA-MODEL #110

Sakurann opened this issue Jul 7, 2022 · 5 comments

Comments

@Sakurann
Copy link
Collaborator

Sakurann commented Jul 7, 2022

Current proposal is here: https://datatracker.ietf.org/doc/html/draft-fett-oauth-selective-disclosure-jwt-01#appendix-A.3
Alternative proposal is here: #103 (comment)

Guess yet another alternative would be:

     "vc": {
       "@context": [
         "https://www.w3.org/2018/credentials/v1",
         "https://www.w3.org/2018/credentials/examples/v1"
       ],
       "type": [
         "VerifiableCredential",
         "UniversityDegreeCredential"
       ],
     "credentialSubject": {
      "given_name": "Alice",
      "sd_digests": {
         "given_name": "fUMdn88aaoyKTHrvZd6AuLmPraGhPJ0zF5r_JhxCVZs",
         "family_name": "9h5vgv6TpFV6GmnPtugiMLl5tHetHeb5X_2cKHjN7cw",
         "birthdate": "fvLCnDm3r4VSYcBF3pIlXP4ulEoHuHOfG_YmFZEuxpQ"
        }
     }
  }
@nikosft
Copy link

nikosft commented Jul 18, 2022

I believe that this alternative violates the definition of SD-JWT in section 4.1. In particular, I uderestand that this alternative is not of the form

SD-JWT-DOC = (METADATA, SD-CLAIMS)

@Sakurann
Copy link
Collaborator Author

yes, the idea was to add a sentence in the SD-JWT specification that profiles of the specification MAY define other places to include sd_digests.

@sbutterfield
Copy link

sbutterfield commented Sep 22, 2022

Just a thought: Should this issue turn in to an extension spec vc-sd-jwt to separate out the responsibility of mapping something foundational (sd-jwt) to something intermediate (vc datamodel)?

@Sakurann Sakurann changed the title SD-JWT as a W3C VC-DATA-MODEL [WIP] SD-JWT as a W3C VC-DATA-MODEL Oct 24, 2022
@Sakurann
Copy link
Collaborator Author

PR #162

@danielfett
Copy link
Member

This has been superseded by the changes we made in PR #174. An example for a W3C VC is contained in the appendix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants