Proposal for blinding claim names #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
requested changes
Jul 14, 2022
peppelinux
approved these changes
Jul 14, 2022
…authstuff/draft-selective-disclosure-jwt into danielfett/blinded-claim-names
|
Spec text updated, please review! |
peppelinux
reviewed
Jul 21, 2022
| 2. For each claim in the SD-JWT Release: | ||
| 1. Ensure that the claim is present as well in `sd_release` in the SD-JWT. | ||
| If `sd_release` is structured, the claim MUST be present at the same | ||
| place within the structure. | ||
| 2. Compute the base64url-encoded hash digest of the JSON literal released | ||
| by the Holder using the `hash_alg` in SD-JWT. | ||
| by the Holder using the `sd_hash_alg` in SD-JWT. |
There was a problem hiding this comment.
@danielfett fixed conflicts and updated this def committing directly in your branch
then I have pushed another commit to fix the previous typo (weird movement on the keyboard?) anyway feel free to rebase these
peppelinux
approved these changes
Jul 21, 2022
peppelinux
reviewed
Jul 21, 2022
|
George during OAuth side mtg pointed out that it is important for the verifier not to change anything in the JSON object in the Release (ie SVC )that is being hashed so that the hash output is the same from the one in SD-JWT |
…e-disclosure-jwt into danielfett/blinded-claim-names
…authstuff/draft-selective-disclosure-jwt into danielfett/blinded-claim-names
Sakurann
reviewed
Aug 5, 2022
Sakurann
reviewed
Aug 5, 2022
| @@ -184,6 +188,8 @@ SD-CLAIMS = ( | |||
| )* | |||
| ``` | |||
|
|
|||
| The claim name (`CLAIM-NAME`) is an optional | |||
There was a problem hiding this comment.
this looks like an unfinished text?
Sakurann
approved these changes
Sep 5, 2022
…authstuff/draft-selective-disclosure-jwt into danielfett/blinded-claim-names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.