Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

You have an undeclared dependency on attrs #21

Closed
FollowTheProcess opened this issue Jan 21, 2022 · 3 comments · Fixed by #22
Closed

You have an undeclared dependency on attrs #21

FollowTheProcess opened this issue Jan 21, 2022 · 3 comments · Fixed by #22

Comments

@FollowTheProcess
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

Hey there! I was using your project and couldn't figure out why I was getting weird errors that didn't show up in my dev environment.

It seems like you use attrs but don't declare it as a dependency in pyproject.toml, my dev environment had it in from some other project hence why I only saw the errors once I installed my project outside the dev environment.

Imported here:

Used here:

But it's not listed in dependencies in pyproject.toml here:

[tool.poetry.dependencies]

When I ran my project I got ModuleNotFoundError and traced it back here.

Expected behavior
A clear and concise description of what you expected to happen.

The dependency should be declared in pyproject.toml

Screenshots
If applicable, add screenshots to help explain your problem.

I forgot to grab any screenshots but I hope the problem is clear

Desktop (please complete the following information):

  • OS: [e.g. iOS] MacOS
  • Version [e.g. 22] Python 3.10.1

Additional context
Add any other context about the problem here.

@obendidi
Copy link
Owner

Thanks for the PR, I'll prepare a new release shortly with the fix ^^

@FollowTheProcess
Copy link
Contributor Author

No worries! Happy to help, great project btw, fits my use case perfectly

@obendidi
Copy link
Owner

obendidi commented Jan 22, 2022

Glad to hear that, don't hesitate if you have any feature requests ^^.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants