Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Recompiler with x86_64 emulation via Unicorn Engine #133

Closed
bayedieng opened this issue Feb 7, 2023 · 1 comment
Closed

Replace Recompiler with x86_64 emulation via Unicorn Engine #133

bayedieng opened this issue Feb 7, 2023 · 1 comment
Assignees
Labels
T-enhancement Type: Enhancement

Comments

@bayedieng
Copy link
Contributor

As recompilation takes significant effort due to sheer amount of x86 instructions, we've decided to shift our efforts CPU emulation using the Unicorn Engine framework. This would be a significant change in the codebase which would allow us to more easily pursue pertinent tasks in regards to supporting ps4 games (e.g. graphics, sound, etc...).

@bayedieng bayedieng added T-enhancement Type: Enhancement L-veteran labels Feb 7, 2023
@bayedieng bayedieng closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2023
@ultimaweapon
Copy link
Member

After we was trying on Unicorn we decided not to go this route and we are going to use https://github.com/bytecodealliance/wasmtime/tree/main/cranelift instead. The reasons are:

  • Unicorn separated the emulated code from the application code, which make it hard to communication between the code that we run in the Unicorn and our application.
  • With the previous reason we need some effort to be able to use it (e.g. implementing a new memory allocator) and if the outcome is not good that mean our effort is losing for nothing.
  • From what we saw on the internet the performance of running x86-64 code with QEMU on AArch64 is not good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-enhancement Type: Enhancement
Development

No branches or pull requests

2 participants