Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New lint: trait becomes unsafe #231

Closed
Tracked by #5
obi1kenobi opened this issue Dec 19, 2022 · 0 comments
Closed
Tracked by #5

New lint: trait becomes unsafe #231

obi1kenobi opened this issue Dec 19, 2022 · 0 comments
Assignees
@staniewzki
Labels
A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

obi1kenobi commented Dec 19, 2022 •
edited

Implementing an unsafe trait requires an unsafe impl block, which is a breaking change: https://doc.rust-lang.org/book/ch19-01-unsafe-rust.html#implementing-an-unsafe-trait

Needs schema additions to expose whether the trait is unsafe:
https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc_json_types/struct.Trait.html
https://github.com/obi1kenobi/trustfall-rustdoc-adapter/blob/0b1f021c22aab6e48f38156e52c7b8331447149a/src/rustdoc_schema.graphql#L382
@obi1kenobi obi1kenobi mentioned this issue Dec 19, 2022
Open
@obi1kenobi obi1kenobi added A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. and removed C-enhancement Category: raise the bar on expectations labels Dec 19, 2022
@obi1kenobi obi1kenobi changed the title trait becomes unsafe New lint: trait becomes unsafe Dec 19, 2022
@obi1kenobi obi1kenobi mentioned this issue Dec 20, 2022
Open
11 tasks
@obi1kenobi obi1kenobi mentioned this issue Dec 27, 2022
Closed
@staniewzki staniewzki self-assigned this Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staniewzki staniewzki

Labels
A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obi1kenobi @staniewzki