Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deprecated attribute API lint, minor incompatibility level #57

Open
1 of 12 tasks
Tracked by #61 ...
epage opened this issue Aug 9, 2022 · 2 comments
Open
1 of 12 tasks
Tracked by #61 ...

Added deprecated attribute API lint, minor incompatibility level #57

epage opened this issue Aug 9, 2022 · 2 comments
Labels
A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@epage
Copy link
Collaborator

epage commented Aug 9, 2022

Semver says deprecations are minor changes.

Reference: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute

Will require separate checks for:

  • items (struct, trait, fn, etc.)
    • struct, enum
    • union
    • trait
    • fn
    • const / static (GlobalValue)
    • other items?
  • enum variants
  • struct fields
  • trait items
  • macro definitions
  • external blocks
@epage epage added A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. labels Aug 9, 2022
@obi1kenobi obi1kenobi added the E-mentor Call for participation: Mentorship is available for this issue. label Aug 10, 2022
@pksunkara
Copy link
Contributor

@obi1kenobi It hasn't been implemented for union. You might want to separate it out from struct & enum in the issue description.

@obi1kenobi
Copy link
Owner

Done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Development

No branches or pull requests

3 participants