Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lints: repr(packed) added or removed on a struct or union #632

Closed
Tracked by #5
obi1kenobi opened this issue Jan 13, 2024 · 0 comments · Fixed by #666
Closed
Tracked by #5

New lints: repr(packed) added or removed on a struct or union #632

obi1kenobi opened this issue Jan 13, 2024 · 0 comments · Fixed by #666
Labels
A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

Both adding and removing repr(packed) is a breaking change when it happens on either structs or unions:
https://doc.rust-lang.org/cargo/reference/semver.html#repr-packed-add
https://doc.rust-lang.org/cargo/reference/semver.html#repr-packed-remove

Adding and removing are definitely going to need separate lints. Whether structs and unions each have their own lints (so, total of 4 lints across all combinations) or we combine them together (so, 2 lints total: repr(packed) added, repr(packed) removed) is up to the implementer.

@obi1kenobi obi1kenobi added A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant