Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-license as Apache/MIT? #84

Closed
Tracked by #61
epage opened this issue Aug 18, 2022 · 4 comments · Fixed by #114
Closed
Tracked by #61

Re-license as Apache/MIT? #84

epage opened this issue Aug 18, 2022 · 4 comments · Fixed by #114
Labels
A-docs Area: documentation for the command and lints C-enhancement Category: raise the bar on expectations M-breaking-change Meta: Implementing or merging this will introduce a breaking change.

Comments

@epage
Copy link
Collaborator

epage commented Aug 18, 2022

Cargo is dual-licensed so I assume dual licensing will make it easier to merge. The sooner, the better to get buy-in from all copyright holders (ie contributors)

Note:: I am speaking from a position of ignorance on licensing

@epage epage added A-docs Area: documentation for the command and lints C-enhancement Category: raise the bar on expectations M-breaking-change Meta: Implementing or merging this will introduce a breaking change. labels Aug 18, 2022
@obi1kenobi
Copy link
Owner

Dual-licensing cargo-semver-checks and its GitHub Action is fine by me.

Would merging into cargo require all dependencies of cargo-semver-checks to be Apache/MIT as well, or can dependencies (e.g. trustfall) remain Apache 2.0? Because that might be trickier and would probably require more work and more conversations.

@epage
Copy link
Collaborator Author

epage commented Aug 18, 2022

The cargo code base itself is Apache/MIT. I am not aware of any part of it that has a different license.

I do not know the state of dependencies.

I also do not know how much the rust project cares one way or the other. This is speculative to remove possible snags from the path to stablization sooner when they are easier to deal with

@obi1kenobi
Copy link
Owner

I'm inclined to complete this this week, while the only commits to the main branch are yours and mine. I'm fine with just mirroring cargo's approach and including both licenses in the repo named LICENSE-APACHE and LICENSE-MIT, then updating Cargo.toml to match.

Do you have a preference between you or me taking this task? Either is fine by me.

@epage
Copy link
Collaborator Author

epage commented Aug 30, 2022

I'm ok either way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for the command and lints C-enhancement Category: raise the bar on expectations M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants