New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't import PSR2 ruleset by default #6
Comments
I have to remove it. It was part of original plan to include PSR-1, not PSR-2 as default. |
Done. 9db4cf6 |
Doesn't same argument apply to PSR-1? Things like camelCase for naming aren't really part of calisthenics rules (from what I understand)? |
@Rarst partially, yes. |
Unfortunately there are rather large legacy projects around (cough WordPress cough).
This isn't actually PSR-1 requirement? As far as I remember all PSR's are fine with multiple definitions in file, it's just not common/convenient (Symfony does this in some places for example). |
I know... I work on some too... =(
IIRC, it was somehow demanded through the PSR-0 as it converted a class to be loaded into a file path. This almost surely enforces the 1 class 1 file rule, because from a vendor library, I could only include one class without loading the other. |
Done as 5fd7ac0 |
Thank you for seeing it from my perspective. :) |
From what I understand PSR-2 isn't really part of calisthenics principles. And some projects aren't PSR-2. And will never be because reasons. :)
With current version of CodeSniffer it's much easier to use multiple rulesets (comma separated list of them), than throw something out (need to create custom ruleset, import another ruleset, then exclude parts you don't need/want).
The text was updated successfully, but these errors were encountered: