Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json "main" should just be JS entry point #5

Closed
isaacs opened this issue Feb 23, 2015 · 3 comments
Closed

package.json "main" should just be JS entry point #5

isaacs opened this issue Feb 23, 2015 · 3 comments

Comments

@isaacs
Copy link
Contributor

isaacs commented Feb 23, 2015

The main field in package.json is set up to be an array. However, this should just be the JavaScript file so that tools like Browserify can know the module's entry point.

It should probably be just src/tipso.min.js. I'm happy to send a PR if you agree.
@isaacs
Copy link
Contributor Author

isaacs commented Feb 23, 2015

Note: I'm not sure how this works with bower.json, so it might be 100% ok there.

@object505
Copy link
Owner

Yes you can send a PR, that would be great.
I have little experience with npm, so If you can also test the package I would be very grateful :)
Thanks 👍

@isaacs isaacs mentioned this issue Feb 23, 2015
Merged
@object505
Copy link
Owner

Merged and updated :)
Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isaacs @object505