Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on_offered_deadline_missed total_count_change not reset #619

Closed
jwillemsen opened this issue Jun 8, 2017 · 2 comments
Closed

on_offered_deadline_missed total_count_change not reset #619

jwillemsen opened this issue Jun 8, 2017 · 2 comments

Comments

@jwillemsen
Copy link
Member

From tests/DCPS/Deadline/run_test.pl, test needs to be extended to check for this

2017-06-08 18:11:33.971@LM_DEBUG@(14829|139909831169792) DataWriterListenerImpl::on_offered_deadline_missed:total_count=5 total_count_change=1 last_instance_handle=11
2017-06-08 18:11:33.971@LM_DEBUG@(14829|139909831169792) DataWriterListenerImpl::on_offered_deadline_missed:total_count=6 total_count_change=2 last_instance_handle=12
2017-06-08 18:11:37.971@LM_DEBUG@(14829|139909831169792) DataWriterListenerImpl::on_offered_deadline_missed:total_count=7 total_count_change=3 last_instance_handle=11
2017-06-08 18:11:37.971@LM_DEBUG@(14829|139909831169792) DataWriterListenerImpl::on_offered_deadline_missed:total_count=8 total_count_change=4 last_instance_handle=12
2017-06-08 18:11:39.468@LM_DEBUG@(14829|139909889521536) Publisher: now verify missed deadline status
2017-06-08 18:11:39.468@LM_DEBUG@(14829|139909889521536) Publisher: got misseddeadline status
2017-06-08 18:11:41.971@LM_DEBUG@(14829|139909831169792) DataWriterListenerImpl::on_offered_deadline_missed:total_count=9 total_count_change=1 last_instance_handle=11
2017-06-08 18:11:41.971@LM_DEBUG@(14829|139909831169792) DataWriterListenerImpl::on_offered_deadline_missed:total_count=10 total_count_change=2 last_instance_handle=12
2017-06-08 18:11:45.971@LM_DEBUG@(14829|139909831169792) DataWriterListenerImpl::on_offered_deadline_missed:total_count=11 total_count_change=3 last_instance_handle=11
2017-06-08 18:11:45.971@LM_DEBUG@(14829|139909831169792) DataWriterListenerImpl::on_offered_deadline_missed:total_count=12 total_count_change=4 last_instance_handle=12
2017-06-08 18:11:49.971@LM_DEBUG@(14829|139909831169792) DataWriterListenerImpl::on_offered_deadline_missed:total_count=13 total_count_change=5 last_instance_handle=11
2017-06-08 18:11:49.971@LM_DEBUG@(14829|139909831169792) DataWriterListenerImpl::on_offered_deadline_missed:total_count=14 total_count_change=6 last_instance_handle=12
2017-06-08 18:11:53.971@LM_DEBUG@(14829|139909831169792) DataWriterListenerImpl::on_offered_deadline_missed:total_count=15 total_count_change=7 last_instance_handle=11
2017-06-08 18:11:53.971@LM_DEBUG@(14829|139909831169792) DataWriterListenerImpl::on_offered_deadline_missed:total_count=16 total_count_change=8 last_instance_handle=12
@jwillemsen
Copy link
Member Author

And also on_requested_deadline_missed

jwillemsen added a commit to jwillemsen/OpenDDS that referenced this issue Nov 2, 2018
@jwillemsen
The total_count_change value should be the incremental changes in tot…
2096298 
…al_count since the last time the listener was called or the status was read. Tested and fixed this for on_offered_deadline_missed and on_requested_deadline_missed, see issue OpenDDS#619

    * dds/DCPS/OfferedDeadlineWatchdog.cpp:
    * dds/DCPS/RequestedDeadlineWatchdog.cpp:
    * tests/DCPS/Deadline/DataReaderListenerImpl.cpp:
    * tests/DCPS/Deadline/DataReaderListenerImpl.h:
    * tests/DCPS/Deadline/DataWriterListenerImpl.cpp:
    * tests/DCPS/Deadline/DataWriterListenerImpl.h:
    * tests/DCPS/Deadline/publisher.cpp:
    * tests/DCPS/Deadline/subscriber.cpp:
@jwillemsen jwillemsen mentioned this issue Nov 2, 2018
Merged
mitza-oci added a commit to mitza-oci/OpenDDS that referenced this issue Nov 2, 2018
@mitza-oci
Cherry-picked only the test changes from PR969:
e48e427 
The total_count_change value should be the incremental changes in total_count since the last time the listener was called or the status was read. Tested and fixed this for on_offered_deadline_missed and on_requested_deadline_missed, see issue OpenDDS#619

    * tests/DCPS/Deadline/DataReaderListenerImpl.cpp:
    * tests/DCPS/Deadline/DataReaderListenerImpl.h:
    * tests/DCPS/Deadline/DataWriterListenerImpl.cpp:
    * tests/DCPS/Deadline/DataWriterListenerImpl.h:
    * tests/DCPS/Deadline/publisher.cpp:
    * tests/DCPS/Deadline/subscriber.cpp:
@mitza-oci mitza-oci mentioned this issue Nov 2, 2018
Closed
@jwillemsen
Copy link
Member Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwillemsen