Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure SEDP association_complete #1227

Merged
merged 1 commit into from Aug 2, 2019

Conversation

jrw972
Copy link
Contributor

@jrw972 jrw972 commented Aug 1, 2019

Sedp writes unsecure data on association complete

Solution: A secure/unsecure SEDP writer should only write local
publications/subscriptions that are secure/unsecure.

@jrw972 jrw972 self-assigned this Aug 1, 2019
Solution: A secure/unsecure SEDP writer should only write local
publications/subscriptions that are secure/unsecure.
@jrw972 jrw972 force-pushed the sedp-secure-unregister-dispose branch from 8c11e9d to c44dc95 Compare August 1, 2019 19:59
@jrw972 jrw972 marked this pull request as ready for review August 1, 2019 20:00
@jrw972 jrw972 requested review from a user and mitza-oci and removed request for a user August 1, 2019 20:00
Copy link
Member

@mitza-oci mitza-oci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, we can merge after CI tests have run successfully and after the 1067 merge.

@mitza-oci mitza-oci merged commit fa120a4 into OpenDDS:master Aug 2, 2019
mitza-oci added a commit that referenced this pull request Aug 14, 2019
Secure SEDP association_complete

(cherry picked from commit fa120a4)

# Conflicts:
#	dds/DCPS/RTPS/Sedp.cpp
#	tools/IntermediateTypeLang/cpp/rapidjson
@jrw972 jrw972 deleted the sedp-secure-unregister-dispose branch November 1, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants