Reactor task in Service Participant has stale reference #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A ReactorTask is an ACE::Task_Base which caches a references to its Thread_Manager. If the Service_Participant is shutdown and ACE is restarted (ACE::fini, ACE::init), then this reference is stale and shows up as an access violation in the Restart test. Solution: Reset the reference when the ReactorTask is stop so that it will use the correct Thread_Mananger when restarted.
mitza-oci
approved these changes
Aug 5, 2019
mitza-oci
added a commit
that referenced
this pull request
Aug 14, 2019
Reactor task in Service Participant has stale reference (cherry picked from commit 2bd9d32) # Conflicts: # tools/IntermediateTypeLang/cpp/rapidjson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ReactorTask is an ACE::Task_Base which caches a references to its
Thread_Manager. If the Service_Participant is shutdown and ACE is
restarted (ACE::fini, ACE::init), then this reference is stale and
shows up as an access violation in the Restart test.
Solution: Reset the reference when the ReactorTask is stop so that it
will use the correct Thread_Mananger when restarted.