Fix to make master build on VS 2019 Version 16.7.0 Preview 1.0 #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitza-oci
approved these changes
May 21, 2020
simpsont-oci
pushed a commit
that referenced
this pull request
Oct 17, 2020
Fix to make master build on VS 2019 Version 16.7.0 Preview 1.0 (cherry picked from commit 05cb7bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed on the mailing list, with VS 2019 V16.7.0 Preview 1.0 there are 9 projects that don't build after doing a default "configure" -> "devenv DDS_TAOv2.sln" -> "Build Solution".
A fix is attached where #include is added to dds/DCPS/Serializer.h so, presumably, something changed recently in VS2019 in relation to its mechanism for working out dependencies.