Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseMojo.java:56-57: Make number of threads used in... #1338

Closed
0pdd opened this issue Oct 14, 2022 · 7 comments
Closed

ParseMojo.java:56-57: Make number of threads used in... #1338

0pdd opened this issue Oct 14, 2022 · 7 comments
Assignees

Comments

@0pdd
Copy link

0pdd commented Oct 14, 2022

The puzzle 1230-026e5a63 from #1230 has to be resolved:

* @todo #1230:30min Make number of threads used in thread executor within {@link #exec()} method
* configurable via mojo parameter `threads`. Default value should be 4.

The puzzle was created by rultor on 14-Oct-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@mximp
Copy link
Contributor

mximp commented Oct 17, 2022

@holydrug please assist

@mximp mximp added enhancement and removed bug labels Oct 17, 2022
@holydrug
Copy link
Contributor

holydrug commented Oct 17, 2022

Should I create overloaded method to be able to pass test without parameter and edit first one method with added default
value? I don't want to edit test or I needed?

@mximp
Copy link
Contributor

mximp commented Oct 17, 2022

@holydrug Just set the default value. I believe there is no need in changing existing tests.

P.S. When writing a comment please mention the user you are addressing it to via @

@mximp
Copy link
Contributor

mximp commented Oct 25, 2022

@holydrug what's up with this?

@holydrug
Copy link
Contributor

@mximp It's a pity but I cannot modify Mojo to be able to pass tests

@mximp
Copy link
Contributor

mximp commented Oct 26, 2022

@holydrug Could you clarify what exactly is failing?

@holydrug
Copy link
Contributor

@mximp Your question made me look into the matter. Does pull request look good? #1338 added number of threads used in thread executor within exec() method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants