#18: revamp Hex #27
Merged
#18: revamp Hex #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 63.06% 63.34% +0.27%
==========================================
Files 16 16
Lines 1565 1596 +31
==========================================
+ Hits 987 1011 +24
- Misses 578 585 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Another change to be mindful of before merging is that I've moved |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a minimal re-implementation of
Hexas per my suggestion in #18.The only breaking API change is that
.bytesis no longer a field, but a method that returns a slice. However, it didn't break anything except the tests, so I don't think changing it will be a problem.