Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy is not part of the build/test #76

Open
yegor256 opened this issue Jan 12, 2023 · 7 comments
Open

clippy is not part of the build/test #76

yegor256 opened this issue Jan 12, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@yegor256
Copy link
Member

When I run cargo build or cargo test, the clippy is not running. I have to do it with an extra step: cargo clippy. Would be great to make this style checker part of the build.

@yegor256 yegor256 added the bug Something isn't working label Jan 12, 2023
@yegor256
Copy link
Member Author

@UARTman please, help

@l3r8yJ
Copy link
Contributor

l3r8yJ commented Feb 28, 2023

@yegor256 can i take this one?

@yegor256
Copy link
Member Author

yegor256 commented Mar 1, 2023

@l3r8yJ yes, please

@l3r8yJ
Copy link
Contributor

l3r8yJ commented Mar 2, 2023

@yegor256 I can make clippy as annoying as possible, do we need it?

@l3r8yJ
Copy link
Contributor

l3r8yJ commented Mar 2, 2023

@yegor256 take a look, please

Here's what looks like a master build with the most complicated settings, can you suggest removing some of them?

@l3r8yJ
Copy link
Contributor

l3r8yJ commented Mar 2, 2023

also, we can add @0pdd to the project and I will create puzzles for each violation, what do you think?

@yegor256
Copy link
Member Author

yegor256 commented Mar 2, 2023

@l3r8yJ yes, of course, let's turn clippy to its maximum power AND make it part of the build in Rultor and in GHA. @0pdd is already in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants