-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hey,TextResult has a big trouble! #25
Comments
Test Code:
it works! 😄 |
Perfect! I always hate when I will try to build a testcase on this, so we can have test infrastructure for similar cases for Madvoc. Thank you! I will soon release a beta snapshot! |
Thanx again, i solved it in the same way and also by using |
but what about other Result(s)?
|
In short, the approach is the following: 1) Madvoc sets the content type and encoding first 2) if the Result wants to modify it, than its his responsibility to do everything right. I know that
Some browsers (like IE) do not like this, and, being strict, that would not be correct. So we introduced
Since no other result is changing the content type, I believe we are fine here. Make sense :)? |
Well, my |
Yes, you are probably using This might be annoying, I agree, but I am not sure how to make a difference when character encoding is missing (i.e. being Sure, I am thinking about caching, for now the only thing I am not sure is how to implement the cache validity check in most pragmatic way? You can send me your idea, no problem with that :) |
it's a piece of cake for me figure out where should reset characterEncoding, however , we should line it out in doc for other guys. [how about:]
no
|
Nice 👍 Please let me check first (write a test) for a |
and #L106 a litte mistake , use |
Haaa, thank you:exclamation: I've just fixed and push the changes - I hate such mistakes, please let me know if you find anything similar :smile: |
Jodd 3.4.3
My code is like:
return "text:this text contents chinese chars 中文 ";
and i got
this text contents chinese chars ??
i have set all environments (os, jvm,netbeans,tomcat,maven) 's characterEncoding to
UTF-8
it may caused by jodd.madvoc.MadvocResponseWrapper.setContentType(), this method will erase responseWrapper.characterEncoding.
waitting for reply ;)
The text was updated successfully, but these errors were encountered: